Skip to content

create strong_password_detection.py #10885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

create strong_password_detection.py #10885

wants to merge 2 commits into from

Conversation

sirilalithaadapa
Copy link

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 24, 2023
cclauss
cclauss requested changes Oct 24, 2023
View reviewed changes
strong_password_detection.py
Comment on lines +1 to +2
def strong_password_detection(password):
AllowedSymbols = ["#", "@", "$", "_", "*", "-"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We require type hints and doctests... Please add tests to cover all the cases below.

Suggested change
def strong_password_detection(password):
AllowedSymbols = ["#", "@", "$", "_", "*", "-"]
def strong_password_detection(password: str) -> bool:
"""
>>> strong_password_detection("str0ng@Password")
True
>>> strong_password_detection("str0ngPassword")
False
"""
allowed_symbols = {c for c in "#@$_*-"}

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 24, 2023
@cclauss cclauss self-assigned this Oct 24, 2023
cclauss
cclauss reviewed Oct 24, 2023
View reviewed changes
strong_password_detection.py
@@ -0,0 +1,42 @@
def strong_password_detection(password):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the filename to strings/strong_password_detection.py

@Akter-Ashik
Copy link

import re

def strong_password_detection(password):
return (
len(password) >= 12 and
any(c.isupper() for c in password) and
any(c.islower() for c in password) and
any(c.isdigit() for c in password) and
any(c in "#@$_*-" for c in password) and
not re.search(r'(.)\1\1', password) and
not any(word.lower() in password.lower() for word in ["password", "admin", "123456", "qwerty"]) and
not any(info.lower() in password.lower() for info in ["john", "doe", "user123"]) and
not re.search(r'123|abc|qwerty', password, re.IGNORECASE)
)

Example usage:

password = "StrongP@ss123!"
if strong_password_detection(password):
print("The password is strong.")
else:
print("The password is weak.")

tianyizheng02
tianyizheng02 reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plagiarized. From a cursory GitHub search, it appears that this code was ultimately taken from https://github.com/HarshCasper/Rotten-Scripts

@tianyizheng02 tianyizheng02 added invalid Plagiarism!! This PR was found to be plagiarized multiple algorithms not allowed Multiple algorithms in a single PR are not allowed hacktoberfest spam Exclude this PR from Hacktoberfest (spam/plagiarism) labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss requested changes

@tianyizheng02 tianyizheng02 tianyizheng02 left review comments

Assignees

@cclauss cclauss

Labels
awaiting changes A maintainer has requested changes to this PR hacktoberfest spam Exclude this PR from Hacktoberfest (spam/plagiarism) invalid multiple algorithms not allowed Multiple algorithms in a single PR are not allowed Plagiarism!! This PR was found to be plagiarized tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirilalithaadapa @Akter-Ashik @cclauss @tianyizheng02